Skip to content

Extract readBuf #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nobu merged 1 commit into from
May 7, 2026
+10 −10
Merged

Extract readBuf #214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions ext/java/org/jruby/ext/stringio/StringIO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1110,11 +1110,7 @@ private IRubyObject readCommon(ThreadContext context, int argc, IRubyObject arg0
final RubyString string;
switch (argc) {
case 2:
str = arg1;
if (!str.isNil()) {
str = str.convertToString();
modifyString((RubyString) str);
}
str = readBuf(arg1);
case 1:
if (!arg0.isNil()) {
len = RubyNumeric.fix2int(arg0);
Expand Down Expand Up @@ -1206,11 +1202,7 @@ private RubyString preadCommon(ThreadContext context, int argc, IRubyObject arg0

switch (argc) {
case 3:
str = arg2;
if (!str.isNil()) {
str = str.convertToString();
modifyString((RubyString) str);
}
str = readBuf(arg2);
case 2:
len = RubyNumeric.fix2int(arg0);
if (!arg0.isNil()) {
Expand Down Expand Up @@ -1702,6 +1694,14 @@ private static IRubyObject substrString(RubyString ch, IRubyObject str, Ruby run
return str;
}

private static IRubyObject readBuf(IRubyObject str) {
if (!str.isNil()) {
str = str.convertToString();
modifyString((RubyString) str);
}
return str;
}

// MRI: strio_write
private long stringIOWrite(ThreadContext context, Ruby runtime, IRubyObject arg) {
checkWritable();
Expand Down
Loading