Skip to content

Merge CI for development branches into ruby-core CI #9260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hsbt merged 3 commits into from
Jan 22, 2026
+15 −122
Merged

Merge CI for development branches into ruby-core CI #9260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d69afd1
Merge CI for development branches into ruby-core CI.
hsbt Jan 22, 2026
cb929e7
Use Ruby 3.4 via ruby/setup-ruby
hsbt Jan 22, 2026
ca7925f
Use ruby/rubygems with Ruby 4.0+
hsbt Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 0 additions & 55 deletions .github/workflows/daily-bundler.yml
View file
Open in desktop

This file was deleted.

63 changes: 0 additions & 63 deletions .github/workflows/daily-rubygems.yml
View file
Open in desktop

This file was deleted.

19 changes: 15 additions & 4 deletions .github/workflows/ruby-core.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,24 +16,29 @@ permissions: # added using https://github.com/step-security/secure-workflows

jobs:
ruby_core:
name: ${{matrix.target}} under a ruby-core setup
name: ${{matrix.target}} under a ruby-core / ${{matrix.branch}}
runs-on: ubuntu-24.04
strategy:
fail-fast: false
matrix:
target: [Rubygems, Bundler]
branch: [ruby_3_4, ruby_4_0, master]
steps:
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
with:
repository: ruby/ruby
path: ruby/ruby
ref: v3_4_5
ref: ${{ matrix.branch }}
Comment on lines 25 to +31
Copy link

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removed daily workflows included Slack notifications (using the 8398a7/action-slack action) that would alert the team when a previously passing build started failing. This notification mechanism has been lost in the consolidation, which may result in failures going unnoticed. Consider adding similar notification logic to the ruby-core workflow or ensuring there's an alternative monitoring mechanism in place.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous hardcoded ref was 'v3_4_5' (a specific release tag), but the new matrix uses branch names like 'ruby_3_4'. This changes the testing behavior from testing against a specific stable release to testing against the tip of a branch. While this may be intentional for development testing, ensure this is the desired behavior. Additionally, 'v3_4_5' appears to be a tag format while the matrix uses branch names, so verify that these branch names exist in the ruby/ruby repository.

Copilot uses AI. Check for mistakes.
persist-credentials: false
- uses: ruby/setup-ruby@b90be12699fdfcbee4440c2bba85f6f460446bb0 # v1.279.0
with:
ruby-version: 3.4
bundler: none
- name: Install libraries
run: |
set -x
sudo apt-get update -q || :
sudo apt-get install --no-install-recommends -q -y build-essential libssl-dev libyaml-dev libreadline6-dev zlib1g-dev libncurses5-dev libffi-dev libgdbm-dev bison autoconf ruby
sudo apt-get install --no-install-recommends -q -y build-essential libssl-dev libyaml-dev libreadline6-dev zlib1g-dev libncurses5-dev libffi-dev libgdbm-dev bison autoconf
- name: Build Ruby
run: |
export GNUMAKEFLAGS="-j$((1 + $(nproc)))"
Expand All @@ -43,8 +48,14 @@ jobs:
working-directory: ruby/ruby
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
with:
path: rubygems/rubygems # We need to backport repository url to sync_default_gems.rb of `ruby_3_4` branch.
path: rubygems/rubygems
persist-credentials: false
if: matrix.branch == 'ruby_3_4'
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
with:
path: ruby/rubygems
persist-credentials: false
if: matrix.branch != 'ruby_3_4'
- name: Sync tools
run: |
ruby tool/sync_default_gems.rb rubygems
Expand Down