Skip to content

Remove obsolete -V short flag from --visibility option #1703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
st0012 merged 2 commits into from
May 9, 2026
+10 −1
Merged

Remove obsolete -V short flag from --visibility option #1703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c60db09
Remove obsolete -V short flag from --visibility option
claude May 9, 2026
133bbe3
Add test for --verbose / -V option parsing
claude May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rdoc/options.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -895,7 +895,7 @@ def parse(argv)

opt.separator nil

opt.on("--visibility=VISIBILITY", "-V", RDoc::VISIBILITIES + [:nodoc],
opt.on("--visibility=VISIBILITY", RDoc::VISIBILITIES + [:nodoc],
"Minimum visibility to document a method.",
"One of 'public', 'protected' (the default),",
"'private' or 'nodoc' (show everything)") do |value|
Expand Down
9 changes: 9 additions & 0 deletions test/rdoc/rdoc_options_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -697,6 +697,15 @@ def test_parse_visibility
assert_equal :nodoc, @options.visibility
end

def test_parse_verbose
@options.parse %w[--verbose]
assert_equal 2, @options.verbosity

@options = RDoc::Options.new
@options.parse %w[-V]
assert_equal 2, @options.verbosity
end

def test_parse_write_options
tmpdir = File.join Dir.tmpdir, "test_rdoc_options_#{$$}"
FileUtils.mkdir_p tmpdir
Expand Down
Loading