Respect encoding option in Prism.lex and friends / Fix ripper encoding handling#4106
Merged
Respect encoding option in Prism.lex and friends / Fix ripper encoding handling#4106
encoding option in Prism.lex and friends / Fix ripper encoding handling#4106Conversation
utf-8 is the default for source files but can be overwritten via options
…lator When no magic encoding comment is present, it does not default to utf-8, and takes the encoding of the string that contains the source code instead. Most of the time that will be utf-8, but not always.
kddnewton
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two separate fixes for truffleruby/truffleruby#4175:
Prism.lex(..., encoding: foo)always created tokens in utf-8 when no magic comment is present, ignoring the passed encodingcc @eregon