Skip to content

Conversation

@herwinw
Copy link
Member

@herwinw herwinw commented Jan 8, 2025

This file has probably been moved at some point, the old version would to lib/mspec/lib which does not exist. The new version is inspired by the syntax of bin/mspec-run to keep things consistent.

Since the usual way to call this script is via bin/mspec-run, and that sets up your load path, an alternative way to fix this would be to simply remove this load path update in this file.

@eregon
Copy link
Member

eregon commented Jan 8, 2025

Mmh, weird, I don't think any of the commands/* files are really meant to be executable.
In fact only 2/5 have executable bits.

Could you remove the #!/usr/bin/env ruby, the load path modifications and the executable bits of lib/mspec/commands/*?

There are launchers for each under bin/ so it seems enough.

There are wrappers for the commands in bin. Remove the executable file
permission, the shebang and the load path modifications.
@herwinw
Copy link
Member Author

herwinw commented Jan 8, 2025

Updated, everything related to executing the files is gone

Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eregon eregon merged commit 0aabb3e into ruby:master Jan 8, 2025
10 checks passed
@herwinw herwinw deleted the mspec-run branch January 8, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants