Skip to content

Support slices change in Prism #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tompng merged 1 commit into from
Jan 28, 2026
Merged

Support slices change in Prism #1168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/irb/nesting_parser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def close_end_keyword_loc(node)
end

def close_closing_loc(node)
close_location(node.closing_loc) unless node.closing.nil? || node.closing.empty?
close_location(node.closing_loc) if node.closing_loc && !node.closing.empty?
end

def visit_for_node(node)
Expand Down Expand Up @@ -220,7 +220,7 @@ def heredoc_string_like(node, type)
if node.opening&.start_with?('<<')
heredoc_open(node)
# Heredoc closing contains trailing newline. We need to exclude it
close_location_start(node.closing_loc) unless node.closing.empty?
close_location_start(node.closing_loc) if node.closing_loc && !node.closing.empty?
elsif node.opening
open_location(node.location, type, node.opening)
if node.closing && node.closing != ''
Expand Down Expand Up @@ -283,7 +283,7 @@ def visit_call_node(node)

if type
open_location(node.opening_loc, type, node.opening)
close_location(node.closing_loc) unless node.closing.empty?
close_closing_loc(node)
end
end

Expand All @@ -298,7 +298,7 @@ def visit_block_parameters_node(node)
def visit_lambda_node(node)
super
open_location(node.opening_loc, :on_tlambeg, node.opening)
close_location(node.closing_loc) unless node.closing.empty?
close_closing_loc(node)
end

def visit_super_node(node)
Expand Down
Loading