Don't use ruby-grape-danger #89
Merged
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
force-pushed
the
migrate-danger-pr-comment
branch
from
a9e01f7 to
f17613e
Compare
Danger ReportNo issues found. |
dblock
force-pushed
the
migrate-danger-pr-comment
branch
from
f17613e to
2b20f59
Compare
dblock
changed the title
numbata
approved these changes
Dec 30, 2025
- Add danger, danger-pr-comment, danger-changelog, and danger-toc to Gemfile - Update Dangerfile to import danger-pr-comment gem - Add changelog.check! and toc.check! to Dangerfile - Follows pattern from slack-ruby/slack-ruby-client#581 and slack-ruby/slack-ruby-bot-server#181 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock
force-pushed
the
migrate-danger-pr-comment
branch
from
2b20f59 to
6583ad7
Compare
Member
Author
|
@numbata I fixed CHANGELOG text, if you're happy with it hit merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we don't need ruby-grape-danger anymore, feels like an unnecessary indirection with very little reuse.