fix: Accept nil serializer#92
Merged
Merged
Conversation
mateusnava
force-pushed
the
fix/serializer-nil
branch
7 times, most recently
from
2b037f7 to
39ed733
Compare
mateusnava
force-pushed
the
fix/serializer-nil
branch
from
39ed733 to
0b98080
Compare
Contributor
Author
|
The error is |
Member
|
Very old but possibly still needed, rebase? |
Member
|
Rubocop is unhappy, please? |
dblock
approved these changes
Jun 8, 2025
dblock
left a comment
dblock
left a comment
Member
There was a problem hiding this comment.
Looks good.
I wonder whether we can memoize @serializer_class ||= ... to improve performance but maybe it doesn't matter.
Not sure what's up with Danger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.