Updated to traverse multiple modulepaths in puppet#8
Open
redstonemercury wants to merge 1 commit intortucker-mozilla:masterfrom
Open
Updated to traverse multiple modulepaths in puppet#8redstonemercury wants to merge 1 commit intortucker-mozilla:masterfrom
redstonemercury wants to merge 1 commit intortucker-mozilla:masterfrom
Conversation
|
@rtucker-mozilla This PR fixes problems for me, can you pull it into the upstream please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the function to traverse multiple paths if they are present in modulepath, and stop when the first location where the specified templates path exists is found. This allows the function to work in cases where the first modulepath is not the one the module using recurse_directory function is located in.
Also, cleaned up some of the indentation just to make it easier for myself to follow what the function was doing. If preferred, I can roll back the indentation changes to make this easier to review.