Open
Conversation
matsl
commented
Mar 23, 2026
| ;; suffixes, so use it only when the file | ||
| ;; either doesn't have a suffix or has a | ||
| ;; library suffix. | ||
| (let ((ext (file-name-extension file))) |
Collaborator
Author
There was a problem hiding this comment.
Uses a let for the free var ext to bind it.
Plus uses when instead of an and to make the intent clearer. IMHO. WDYT?
Also fixes the indentation that was a bit off.
Note
The comment does not align properly too so looks odd here in the web interface. I think it is due to a mix of space and tabs in the file. I was thinking of fixing the whitespace in the file but decided to postpone this as a separate step since it would make reviewing these small changes much harder. Let me know if I can fix the whitespace in hibtypes.el as a separate commit to this PR or if we wait with that.
* hibtypes.el (hib-link-to-file-line): Use let for undefined free var
ext. Fix indentation.
* hywiki.el (consult-grep-args, consult-ripgrep-args): Defvar consult
variables.
(hywiki-org-to-heading-instance): Use with-suppressed-warnings for
obsolete org-show-entry.
* hui-mouse.el (profiler-report-find-entry)
(profiler-report-toggle-entry): Declare functions. Sort the functions.
(smart-profiler-report): Shorten docstring line below 80
chars. Do explicit initialization of curr-buffer since
byte-compiler does not see it will be set.
matsl
force-pushed
the
pr_remove_warnings
branch
from
8d1a023 to
8f27538
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Silence byte compilation warnings.
Why
Warnings can indicate issues so we keep them low so that they are easy
to spot and act on.
Note
I missed to cook up a ChangeLog update for this. But it made rebase a breeze. I'll add that later today.The ChangeLog is added.Maybe I should always just add the ChangeLog item as a comment to be inserted when the PR is merged? It is 99% of the time a conflict in the ChangeLog that cause conflicts and requires rebasing. 😄