Conversation
Fix problems in functions under test: - hywiki-word-create: Eliminate redundant term. - hywiki-create-page: Let page-file be the name of the file. User-error when page-file is not created.
matsl
commented
Feb 8, 2026
| (hattr:set 'hbut:current 'referent-value referent-value)) | ||
| (cond ((fboundp display-function) | ||
| (funcall display-function wikiword referent-value)) | ||
| ((symbolp referent-type) |
Collaborator
Author
There was a problem hiding this comment.
This can't be reached since symbol-name on line 880 will raise an error.
matsl
commented
Feb 8, 2026
| (user-error "(hywiki-create-page): Invalid HyWikiWord: '%s'; must be capitalized, all alpha" wikiword)) | ||
| (if page-file | ||
| (message "HyWikiWord '%s' page: \"%s\"" wikiword page-file) | ||
| (user-error "(hywiki-create-page): Invalid HyWikiWord: '%s'; must be capitalized, all alpha" wikiword))) |
Collaborator
Author
There was a problem hiding this comment.
Formatting looks strange in the diff here. I think it is due to space and tabs. Maybe we should look over our code style to ensure we use the same whitespace conventions to make the diffs easier to read.
Owner
There was a problem hiding this comment.
I agree; it is annoying. I allow for tabs right now and use default wmacs tab soacing, I believe.
Owner
|
Let's go through this together today and we'll get merged with a few updates. |
rswgnu
approved these changes
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Update and add hywiki tests
Fix problems in functions under test:
when page-file is not created.
Why
More tests.