refactor: modernize react refresh runtime helpers#98
Merged
chenjiahan merged 4 commits intomainfrom Apr 8, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes the React Refresh client/runtime helper code while aiming to preserve existing runtime behavior (notably around async exports and refresh boundary detection).
Changes:
- Refactors refresh helpers to use
const/let, arrow functions, template literals, and simplified control flow. - Keeps existing refresh boundary/signature logic intact while reducing boilerplate in
shouldInvalidateReactRefreshBoundaryand HMR handlers. - Minor style/consistency updates in the React Refresh entry/runtime wiring.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| client/refreshUtils.js | Refactors module export extraction, boundary signature/invalidation, debounce update helper, and HMR dispose/accept handlers. |
| client/reactRefreshEntry.js | Modernizes safeThis/global detection and injected-flag string building. |
| client/reactRefresh.js | Simplifies refresh execution path and test-mode resolution while preserving Promise vs non-Promise export handling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
const, arrow functions, template literals, and simpler control flow__esModule-only refresh boundaries while cleaning up the implementationTesting
pnpm testRelated Links