Skip to content

release: v2.0.0 #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 2 commits into from
Apr 8, 2026
Merged

release: v2.0.0 #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e98ba3c
fix: workflow
chenjiahan Apr 8, 2026
30677cb
chore: release v2.0.0
chenjiahan Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ jobs:
- name: Publish
uses: JS-DevTools/npm-publish@v4
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JS-DevTools/npm-publish is referenced by a moving tag (@v4). In this repo, other workflows pin third-party actions to a specific commit SHA (e.g. actions/checkout / actions/setup-node in .github/workflows/test.yml). Please pin this action to a commit SHA as well to reduce supply-chain risk and ensure deterministic releases.

Suggested change
uses: JS-DevTools/npm-publish@v4
uses: JS-DevTools/npm-publish@<FULL_COMMIT_SHA_FOR_THE_INTENDED_V4_RELEASE>

Copilot uses AI. Check for mistakes.
with:
# TODO: remove beta tag before release stable
tag: beta
token: empty
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The publish step sets token: empty, which will cause npm-publish to be unable to authenticate to npm and likely fail the release workflow. This should be wired to a real token/secret (or switched to an auth mechanism the action supports) rather than a placeholder value.

Suggested change
token: empty
token: ${{ secrets.NPM_TOKEN }}

Copilot uses AI. Check for mistakes.

- name: Create GitHub Release
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@rspack/plugin-react-refresh",
"version": "2.0.0-beta.0",
"version": "2.0.0",
"repository": "https://github.com/rstackjs/rspack-plugin-react-refresh",
"license": "MIT",
"description": "React refresh plugin for Rspack",
Expand Down
Loading