Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on updating the project's core Rspack dependencies to the latest Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Pull request overview
Upgrades the repository’s Rspack dependencies to 2.0.0-beta.7, refreshes generated artifacts affected by the upgrade (lockfile + overlay snapshots), and adjusts the E2E test runner settings to improve stability.
Changes:
- Bump
@rspack/core(and example@rspack/cli/@rspack/core) to2.0.0-beta.7and refreshpnpm-lock.yaml. - Update overlay E2E snapshots to match beta.7 overlay/output formatting.
- Run rstest serially with increased local timeouts to reduce E2E flakiness from fixed ports/browser spawning.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e/snapshots/overlay.test.js.snap | Snapshot updates for overlay HTML changes from Rspack beta.7 output. |
| rstest.config.ts | Forces serial execution and increases timeouts to stabilize E2E runs. |
| pnpm-lock.yaml | Lockfile refresh reflecting beta.7 upgrades and dependency graph changes. |
| package.json | Bumps devDependency @rspack/core to 2.0.0-beta.7. |
| example/package.json | Bumps example @rspack/cli and @rspack/core to 2.0.0-beta.7. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| '@rspack/core@2.0.0-beta.7': | ||
| resolution: {integrity: sha512-JbLVx0RptvNvPx3Tj+b96v4lxLvcV9YId2VWJ1DmYlQ+oFJJrjjdQtr3KJitU5tEIySW1CqD1R6qxU3BzpwEjw==} | ||
| engines: {node: ^20.19.0 || >=22.12.0} | ||
| peerDependencies: | ||
| '@module-federation/runtime-tools': ^0.24.1 || ^2.0.0 |
| ], | ||
| pool: { | ||
| maxWorkers: '80%', | ||
| // E2E tests reuse fixed ports and spawn browsers, so serial execution is more stable. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades @rspack/core and @rspack/cli to version 2.0.0-beta.7. Consequently, the lockfile and test snapshots have been updated. The test configuration has also been modified to run tests serially with increased local timeouts to improve stability. The changes are consistent with the goal of upgrading dependencies and appear correct.
Summary
Testing