Open
Conversation
The use of await when handling the "initially" WebSocket message may cause incoming messages to be lost. Event handlers like `ws.on('message', ...)` may not get installed until after the asynchronous method completes, so any WebSocket events during that time period aren't handled.
Fixes rse#20
Owner
|
Yes, correct: the "await" for the initial injected HTTP message might need more time than the arrival of the first Websocket message. But the solution is not such easy as to just use a promise callback instead, because the authorization has to be checked by the initial simulated HTTP request before a Websocket message should be processed. I've to look what the more correct solution is to resolve your issue and NOT cause a security issue. |
WebSocket messages should not be processed until `initially` has finished and has a chance to optionally close the connection completely. Disconnects and protocol-level errors are processed regardless - these occur at a lower level and should be preserved for consistency with connects.
Contributor
Author
|
@rse Thank you for pointing that out. I just pushed a potential fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The use of await when handling the "initially" WebSocket message may cause incoming messages to be lost. Event handlers like
ws.on('message', ...)may not get installed until after the asynchronous method completes, so any WebSocket events during that time period aren't handled.Fixes #20