Skip to content

fix: fix ssr builds #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jakobrosenberg wants to merge 3 commits into
base: updates
Choose a base branch
from
Open

fix: fix ssr builds #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8638a8
fix: fix ssr builds
jakobrosenberg May 24, 2022
0f44231
chore: use dynamic compile option
jakobrosenberg May 27, 2022
01c5483
fix: bump version selector
jakobrosenberg Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,15 @@
"name": "v2.routify.dev",
"private": true,
"license": "MIT",
"type": "module",
"scripts": {
"dev": "run-p dev:*",
"dev:routify": "routify",
"dev:vite": "vite",
"build": "run-s build:*",
"build:routify": "routify -b",
"build:vite": "vite build",
"build:client": "vite build --outDir dist/client",
"build:server": "vite build --outDir dist/server --ssr src/main.js",
"build:static": "spank",
"build:search": "poindexter",
"assets": "pwa-asset-generator public/logo-square.svg public/icons/pwa --background \"#FFFFFF\" --padding \"16px\"",
Expand Down Expand Up @@ -60,9 +62,9 @@
]
},
"spank": {
"entrypoint": "dist/index.html",
"script": "dist/main.js",
"output": "dist",
"inlineDynamicImports": true,
"entrypoint": "dist/client/index.html",
"script": "dist/server/main.js",
"output": "dist/server",
"inlineDynamicImports": false
}
}
6 changes: 3 additions & 3 deletions src/components/VersionSelector.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<script>
let initial = 'https://routify.dev'
let initial = 'https://v2.routify.dev'
let selected = initial

$: if(initial !== selected) window.location.href = selected
Expand All @@ -22,6 +22,6 @@

<select bind:value={selected}>
<option value="https://v1.routify.dev">1.x</option>
<option value="https://routify.dev">2.x</option>
<option value="https://v3.routify.dev">3.x</option>
<option value="https://v2.routify.dev">2.x</option>
<option value="https://routify.dev">3.x</option>
</select>
3 changes: 0 additions & 3 deletions src/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,3 @@ import '../scss/global.scss';
registerSW()();

const app = HMR(App, { target: document.body }, 'routify-app')

export default app;

5 changes: 3 additions & 2 deletions vite.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { resolve } from "path";
import slug from "remark-slug";

export default defineConfig({
ssr: { noExternal: true },
plugins: [
svelte({
preprocess: [
Expand All @@ -22,7 +23,7 @@ export default defineConfig({
}),
preprocess(),
],

experimental: { dynamicCompileOptions: () => ({ generate: "dom" }) },
extensions: [".svelte", ".md"],
}),
VitePWA({
Expand Down Expand Up @@ -62,7 +63,7 @@ export default defineConfig({
],
},
}),
main()
main(),
],

resolve: {
Expand Down