[WIP] Flamegraph generation for rootbench.git#94
[WIP] Flamegraph generation for rootbench.git#94HLilit wants to merge 14 commits intoroot-project:masterfrom
Conversation
Co-Authored-By: Vassil Vassilev <v.g.vassilev@gmail.com>
It could be invocated from Cmake or as a standalone.
| @@ -0,0 +1 @@ | |||
| RooFit.Banner: no | |||
There was a problem hiding this comment.
Could you add a comment, explaining why we need this?
There was a problem hiding this comment.
Anything that had been even linked with Roofit will automatically have a Roofit banner as a part of output. Only way to suppress it is to put a .rootrc with suppression setting in a place where binary will be executed (by default in ROOT master suppression is OFF and I didn't manage to convince to remove it, since it is a part of ownership notification).
rootbench-scripts/flamegraph.sh
Outdated
| #!/bin/bash | ||
|
|
||
| BENCHMARKPATTERN="*benchmark*" | ||
| MKDIR=/bin/mkdir |
There was a problem hiding this comment.
We should use MKDIR=$(which mkdir). Likewise for the rest.
rootbench-scripts/flamegraph.sh
Outdated
| echo "Can't create directory $1. Exiting..." | ||
| exit 1 | ||
| fi | ||
| for bm in $bm_sub_list |
There was a problem hiding this comment.
Could you run this script through a bash code formatter tool? Indentations and new lines seem non-standard.
|
Closing because I moved development in #192 (hopefully we can merge it soon!) |
3 participants
No description provided.