Improved benchmarking of compression algorithms#225
Improved benchmarking of compression algorithms#225oshadura wants to merge 1 commit intoroot-project:masterfrom
Conversation
I added a new CMake option: experiment-datafiles - that allows to download experiments files (CMS, ATLAS) that are bigger then 1.5 GB
eguiraud
left a comment
eguiraud
left a comment
There was a problem hiding this comment.
Hi Oksana, looks good except the questions below.
I can't comment on whether the pattern
auto newtree = oldtree->CloneTree();
timer.Start();
newfile->Write();
timer.Stop()
does what we want, but you know better.
The RDF benchmarks look ok as long as we remember that they measure both the writing and the data generation, differently from the other benchmarks.
| double rtime = timer.RealTime(); | ||
| double ctime = timer.CpuTime(); | ||
| // For Run2012B_DoubleMuParked.root: | ||
| float size_mb = 774.619423; |
There was a problem hiding this comment.
these hardcoded values are a bit "scary", can we get them programmatically?
| if(experiment-datafiles) | ||
| # We need to enable download of datafiles from oot.cern.ch | ||
| set(rootbench-datafiles ON CACHE BOOL "Download files from root.cern.ch" FORCE) | ||
| endif() No newline at end of file |
There was a problem hiding this comment.
why do we need a separate option? other files downloaded if rootbench-datafiles is on are not much smaller, and now we have two options that we need to set to get all benchmarks.
if we need the option, why does it imply root-benchdatafiles=ON? it would be simpler to keep them orthogonal - one turns on some benchmarks, the other turns on some other.
if we need the second option, it needs at least to be mentioned in the README.
2 participants
I added a new CMake option: experiment-datafiles - that allows to download experiments files (CMS, ATLAS) that are bigger then 1.5 GB
I also used these benchmarks for testing FLZMA2 (suggestions are welcomed!)
(this pr replaces #216)