[Python] Prevent possible double pythonization of template classes#22256
Merged
Conversation
If the current C++ global namespace containts both template instantiations and the original class template, which can happen depending on the usage pattern, it can happen that the same template instance is pythonized twice. This is prevented with additional conditionals in the pythonization code paths.
Test Results 22 files 22 suites 3d 10h 25m 13s ⏱️ Results for commit 7489a25. |
vepadulano
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the current C++ global namespace containts both template instantiations and the original class template, which can happen depending on the usage pattern, it can happen that the same template instance is pythonized twice. This is prevented with additional conditionals in the pythonization code paths.