[cling][JIT] Inject ORC perf symbols into the process JITDylib#22255
Open
devajithvs wants to merge 1 commit into
Open
[cling][JIT] Inject ORC perf symbols into the process JITDylib#22255devajithvs wants to merge 1 commit into
devajithvs wants to merge 1 commit into
Conversation
LLVM ORC's perf support plugin expects the symbols `llvm_orc_registerJITLoaderPerf*` to be resolvable through the process symbol table. When ROOT is built, these symbols are hidden in libCling.so and cannot be resolved. Enabling perf fails when the plugin attempts to look them up. This is similar to the existing manual symbol injection for compiler-rt helpers on macOS and for symbols in libc_nonshared.a.
Test Results 22 files 22 suites 3d 9h 4m 41s ⏱️ Results for commit 508f144. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLVM ORC's perf support plugin expects the symbols
llvm_orc_registerJITLoaderPerf*to be resolvable through the process symbol table.When ROOT is built, these symbols are hidden in libCling.so and cannot be resolved. Enabling perf fails when the plugin attempts to look them up.
This is similar to the existing manual symbol injection for compiler-rt helpers on macOS and for symbols in libc_nonshared.a.
You will still need perf-inject step.
Related: #21940
CC: @vepadulano