Skip to content

[afterimage] migrate from configure-make to CMake and merge with Windows#21649

Draft
ferdymercury wants to merge 2 commits intoroot-project:masterfrom
ferdymercury:asimagecmake
Draft

[afterimage] migrate from configure-make to CMake and merge with Windows#21649
ferdymercury wants to merge 2 commits intoroot-project:masterfrom
ferdymercury:asimagecmake

Conversation

@ferdymercury
Copy link
Collaborator

@ferdymercury ferdymercury commented Mar 20, 2026

Sub-part of work towards #9090

Skipping CI for the moment since it's just explorative and most surely it will fail on Windows. And also for waiting first for feedback whether this is wanted.
Builds locally as standalone project as well as part of my ROOT build, on my Ubu22.

@ferdymercury ferdymercury added the skip ci Skip the full builds on the actions runners label Mar 20, 2026
@ferdymercury ferdymercury changed the title [skip-ci] migrate from configure-make to CMake and merge with Windows [afterimage] migrate from configure-make to CMake and merge with Windows Mar 20, 2026
@dpiparo
Copy link
Member

dpiparo commented Mar 21, 2026

Thanks for kicking off this improvement in uncharted territory! May I ask why skip-ci? Don't we maybe want to see this in action, to discover the failures not initially foreseen?

@ferdymercury
Copy link
Collaborator Author

Thanks!

May I ask why skip-ci? Don't we maybe want to see this in action, to discover the failures not initially foreseen?

At this stage, it only builds standalone, but not as part of the ROOT build. So for sure the CI will fail, thus I wanted first to fix that part locally and then remove the skipci label

@ferdymercury ferdymercury removed the skip ci Skip the full builds on the actions runners label Mar 22, 2026
@ferdymercury
Copy link
Collaborator Author

ferdymercury commented Mar 22, 2026

Now it builds as part of ROOT in my Ubu22 system

@ferdymercury ferdymercury requested a review from dpiparo March 22, 2026 22:57
@github-actions
Copy link

Test Results

    15 files      15 suites   1d 23h 47m 52s ⏱️
 3 811 tests  3 810 ✅ 0 💤  1 ❌
51 132 runs  51 119 ✅ 0 💤 13 ❌

For more details on these failures, see this check.

Results for commit 8dac2d9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants