[hist] Move underflow bin before normal bins #21168
Open
+71
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bit more complicated in the code because the shift only applies if the underflow bin is enabled. It is also slower in the existing microbenchmarks, in particular with Clang. However, we need to make this change in order to support UHI's values(flow=True) with zero-copy buffers in the future and have the underflow bin at "the right place." Otherwise the design currently treats the memory layout as an internal implementation detail that users will not notice when using RBinIndex.
Test Results 22 files 22 suites 3d 18h 16m 11s ⏱️ Results for commit 33772a1. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit more complicated in the code because the shift only applies if the underflow bin is enabled. It is also slower in the existing microbenchmarks, in particular with Clang. However, we need to make this change in order to support UHI's
values(flow=True)with zero-copy buffers in the future and have the underflow bin at "the right place." Otherwise the design currently treats the memory layout as an internal implementation detail that users will not notice when usingRBinIndex.