[Python] Use relative imports in Python modules #21167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guitargeek
force-pushed
the
relative_imports
branch
6 times, most recently
from
c8a0ee5 to
f484533
Compare
Test Results 22 files 22 suites 3d 16h 53m 51s ⏱️ Results for commit 087a33a. ♻️ This comment has been updated with latest results. |
It's better to explicitly check if the dependencies are avaialble rather than barring whole code sections behind a `try-except ImportError`. Otherwise, we're not letting surface other import errors in our own code, making them difficult to debug.
Make sure the context destructor is called: don't rely on Python garbage collection. This was spotted by a ruff unused variable warning.
Using relative imports is better, because we can freely change the names of modules without having to update hardcoded import paths.
guitargeek
force-pushed
the
relative_imports
branch
2 times, most recently
from
8fcd2c8 to
feb5d20
Compare
guitargeek
force-pushed
the
relative_imports
branch
from
feb5d20 to
087a33a
Compare
vepadulano
approved these changes
Feb 5, 2026
Member
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
I don't agree that using relative imports it's better, it's a choice. But I'm not opposed to the changes per se.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using relative imports is better, because we can freely change the names of modules without having to update hardcoded import paths.