[hist] prevent TFormula out of bounds access#21110
Open
ferdymercury wants to merge 8 commits intoroot-project:masterfrom
Open
[hist] prevent TFormula out of bounds access#21110ferdymercury wants to merge 8 commits intoroot-project:masterfrom
ferdymercury wants to merge 8 commits intoroot-project:masterfrom
Conversation
vepadulano
reviewed
Feb 2, 2026
Test Results 22 files 22 suites 3d 15h 11m 43s ⏱️ For more details on these failures, see this check. Results for commit d572c47. ♻️ This comment has been updated with latest results. |
set IsValid to false otherwise while constructing TFormula
Collaborator
Author
|
For the test failure, I think it's due to the logic applied here (dcf9209#r176468371) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Fixes #21104
Checklist: