Skip to content

[ntuple] Add RPageSinkFile::CloneWithDifferentName#21063

Merged
silverweed merged 1 commit intoroot-project:masterfrom
silverweed:ntuple_sink_clone
Feb 5, 2026
Merged

[ntuple] Add RPageSinkFile::CloneWithDifferentName#21063
silverweed merged 1 commit intoroot-project:masterfrom
silverweed:ntuple_sink_clone

Conversation

@silverweed
Copy link
Contributor

@silverweed silverweed commented Jan 29, 2026

Last part of #19904.

Adds a writing analogue to RPageSourceFile::OpenWithDifferentAnchor, which allows to derive a new Sink from an existing one using the same underlying directory but writing to a different RNTuple.
Was previously called DeriveFor but I found the name too obscure and I think this is clearer.

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@github-actions
Copy link

github-actions bot commented Jan 29, 2026

Test Results

    22 files      22 suites   3d 9h 22m 25s ⏱️
 3 776 tests  3 774 ✅ 0 💤 2 ❌
75 119 runs  75 117 ✅ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit c8e2b81.

♻️ This comment has been updated with latest results.

@silverweed silverweed marked this pull request as draft January 29, 2026 12:10
@silverweed silverweed marked this pull request as ready for review January 29, 2026 12:23
@pcanal
Copy link
Member

pcanal commented Jan 29, 2026

which allows to derive a new Sink from an existing one using the same underlying directory but writing to a different RNTuple.

Do we also need to support the case where the user would like to clone in a different directory (and/or is it mostly for internal use)?

@silverweed
Copy link
Contributor Author

which allows to derive a new Sink from an existing one using the same underlying directory but writing to a different RNTuple.

Do we also need to support the case where the user would like to clone in a different directory (and/or is it mostly for internal use)?

It's for internal use only (for the Attributes) and we always want to write to the same directory

@silverweed silverweed force-pushed the ntuple_sink_clone branch 2 times, most recently from fa2b7b6 to 53d06d8 Compare February 5, 2026 08:22
Writing analogue to RPageSourceFile::OpenWithDifferentAnchor, it allows
to derive a new Sink from an existing one using the same underlying
directory but writing to a different RNTuple.
@silverweed silverweed merged commit ffb663e into root-project:master Feb 5, 2026
27 of 30 checks passed
@silverweed silverweed deleted the ntuple_sink_clone branch February 5, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants