[CMake] Don't set ROOTSYS in rootcling_stage1 #20995
Open
+3
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During build time, the build directory path has to be fixed anyway, so we might as well hardcode it in the `rootcling_stage1` executable. This implements a suggestion by @pcanal in this comment: root-project#20828 (comment) It's one more step towards completely avoiding the need for the `ROOTSYS` environment variable.
guitargeek
added
in:Build System
clean build
Test Results 22 files 22 suites 3d 12h 44m 46s ⏱️ Results for commit 7d685c7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During build time, the build directory path has to be fixed anyway, so we might as well hardcode it in the
rootcling_stage1executable.This implements a suggestion by @pcanal in this comment: #20828 (comment)
It's one more step towards completely avoiding the need for the
ROOTSYSenvironment variable.