[build] Unify retrieval of MacOS SDK path #20991
Merged
+8
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vepadulano
added
in:Build System
clean build
Test Results 22 files 22 suites 3d 9h 43m 24s ⏱️ Results for commit 0e15005. ♻️ This comment has been updated with latest results. |
vepadulano
removed
the
build-python-wheels
Use `xcrun --show-sdk-path` only once to set the CMAKE_OSX_SYSROOT variable and then reuse it also for the modulemap fix on Darwin. Since the modulemap fix needed the `xcrun` command to work anyway, turn the warning previously issued if CMake couldn't find this command to an error.
vepadulano
force-pushed
the
reuse-xcrun-output
branch
from
a6c69dd to
0e15005
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
xcrun --show-sdk-pathonly once to set the CMAKE_OSX_SYSROOT variable and then reuse it also for the modulemap fix on Darwin.Since the modulemap fix needed the
xcruncommand to work anyway, turn the warning previously issued if CMake couldn't find this command to an error.