[ci] Use C++20 also in the nightly build with cmake_cxxmodules=OFF
#20989
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids surprises where fragile test failures with C++17 and modules=OFF cannot be anticipated from the PR builds.
The test in question is in
test_datatypes.pyin the cppyy test suite:=================================== FAILURES =================================== ____________________ TestDATATYPES.test49_addressof_method _____________________ self = <test.test_datatypes.TestDATATYPES object at 0x7fb5a77f3200> @mark.xfail(strict=True, condition=IS_MAC_ARM or IS_WINDOWS, reason="Crashes on mac-beta ARM64 and fails on Windows") def test49_addressof_method(self): """Use of addressof for (const) methods""" import cppyy > assert cppyy.addressof(cppyy.gbl.std.vector[int].at.__overload__(':any:', False)) E AssertionError: assert 0 E + where 0 = <built-in function addressof>(<cppyy.CPPOverload object at 0x7fb5a7a62000>) E + where <built-in function addressof> = <module 'cppyy' from '/github/home/ROOT-CI/build/lib/cppyy/__init__.py'>.addressof E + and <cppyy.CPPOverload object at 0x7fb5a7a62000> = <built-in method __overload__ of cppyy.CPPOverload object at 0x7fb5a7aaaa00>(':any:', False) E + where <built-in method __overload__ of cppyy.CPPOverload object at 0x7fb5a7aaaa00> = <cppyy.CPPOverload object at 0x7fb5a7aaaa00>.__overload__ E + where <cppyy.CPPOverload object at 0x7fb5a7aaaa00> = <class cppyy.gbl.std.vector<int> at 0x5628463dfb40>.at ../../../../../../src/bindings/pyroot/cppyy/cppyy/test/test_datatypes.py:2348: AssertionError ----------------------------- Captured stderr call ----------------------------- input_line_412:2:106: error: 'RActivePhysicalColumns' is a protected member of 'ROOT::Internal::RPageSource' (vector<int>::reference (std::vector<int, std::allocator<int> >::*)(vector<ROOT::Internal::RPageSource::RActivePhysicalColumns::RColumnInfo>::size_type))&std::vector<int, std::allocator<int> >::at ^ /github/home/ROOT-CI/build/include/ROOT/RPageStorage.hxx:653:10: note: declared protected here class RActivePhysicalColumns { ^ =========================== short test summary info ============================