[cmake][win] Fix compilation errors with /std:c++20 #20987
+1
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 22 files 22 suites 3d 12h 41m 24s ⏱️ Results for commit 6a350c8. |
pcanal
reviewed
Jan 22, 2026
pcanal
reviewed
Jan 23, 2026
| set(CMAKE_SUPPRESS_REGENERATION TRUE) | ||
| set(libsuffix .dll) | ||
| set(exesuffix .exe) | ||
| set(CMAKE_CXX_FLAGS "/nologo /Zc:__cplusplus /MD /GR /EHsc- /W3 /D_WIN32") |
Member
There was a problem hiding this comment.
Could you extend the git log to explain why this is no longer needed?
Removes the `CMAKE_CXX_FLAGS` that was intended for standalone roottest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.