Fix watch mode errors on scope changes after transpilation#1422
Closed
luis-j-soares wants to merge 3 commits intorokucommunity:masterfrom
Closed
Fix watch mode errors on scope changes after transpilation#1422luis-j-soares wants to merge 3 commits intorokucommunity:masterfrom
luis-j-soares wants to merge 3 commits intorokucommunity:masterfrom
Conversation
Collaborator
Author
|
Closing this as I can't find a solution, and it's likely better to focus on this for the v1 branch. Opened #1613 instead so we can track it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix a watch mode issue where field initialisers will trigger diagnostic errors after their scope is transpiled.
Notes:
because fixing this with.clone()breaks enums. Still figuring out how to fix that..clone()solution because it conflicts with how thetranspilemethod of enum/const value expressions are overwritten byeditor. It might be better to clone the entire AST before transpiling the file, but that might incur its own issues...parentreferences, which delays transpiling times;