Skip to content

Correction de l'encodage de TiffDeflateEncoder #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dolite merged 3 commits into from
Feb 17, 2025
Merged

Correction de l'encodage de TiffDeflateEncoder #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
817b39f
Correction du retour lors du flush S3
Dolite Jan 21, 2025
e2370cc
Correction de l'encodage dans TiffDeflateEncoder
Dolite Feb 17, 2025
2adb98c
Complétion du changelog
Dolite Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
## 2.0.2

### [Fixed]

* `TiffDeflateEncoder` : l'encodage du résultat final n'est pas en deflate (seule la donnée dans le tiff l'est, et non le résultat complet)
* `S3Context` : on retourne bien false lorsqu'une erreur est rencontrée lors du flush (close_to_write)


## 2.0.1

### [Added]
Expand Down
2 changes: 1 addition & 1 deletion include/rok4/datastream/TiffDeflateEncoder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ class TiffDeflateEncoder : public TiffEncoder {
}

std::string get_encoding() {
return "deflate";
return "";
}
};

Expand Down
2 changes: 1 addition & 1 deletion src/storage/S3Context.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,7 +656,7 @@ bool S3Context::close_to_write(std::string name) {

BOOST_LOG_TRIVIAL(error) << "Unable to flush " << it1->second->size() << " bytes in the S3 object " << bucket_name << "@" << ((cluster_name != "") ? cluster_name : host) << " / " << name << " after " << write_attempts << " tries" ;

return true;
return false;
}

bool S3Context::exists(std::string name) {
Expand Down