Skip to content

Conversation

@jdw170000
Copy link
Contributor

This PR makes two changes to END_ASYNC_FOR in Python 3.14:

  1. The Delta argument is now treated as negative.
  2. The jump formatting now matches dis, saying "from XYZ" instead of "to XYZ"

The change to END_ASYNC_FOR is not yet documented in dis, but there is an open issue on the CPython github with an associated pull request to update the documentation.

@rocky rocky changed the base branch from python-3.14 to master December 11, 2025 22:45
if isinstance(arg_val, str)
else repr(arg_val)
)
arg_repr = prefer_double_quote(repr(arg_val)) if isinstance(arg_val, str) else repr(arg_val)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I keep seeing gratuitous changes like this. I would be grateful if we could stop with the formatting wars.

I am using black 25.12.0. What is it that causes this formatting?

Is .editorconfig get read in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using the Ruff VSCode extension with black 24.10.0. I think the issue is that my formatter's line length was set to a longer value than the default 88 characters, so it was unwrapping lines in the files I was updating.

I'll set it back to 88 so hopefully I can avoid having so much linter noise in future PRs.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Does adding this pyproject.toml help:

[tool.black]
line-length = 88 

If there's something we can do to make things explicit, that'd be good.

I am not opposed to a longer line limit, but I am opposed to formatting wars.

@rocky rocky merged commit b3bc2d7 into rocky:master Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants