Skip to content

disable version check if telemetry is disabled#2046

Merged
RoiGlinik merged 1 commit intomasterfrom
block-saas-api-call
Apr 9, 2026
Merged

disable version check if telemetry is disabled#2046
RoiGlinik merged 1 commit intomasterfrom
block-saas-api-call

Conversation

@arikalon1
Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 10e8e496-c576-4b3a-921b-1a30784098c0

📥 Commits

Reviewing files that changed from the base of the PR and between 7c8d299 and e564ab2.

📒 Files selected for processing (1)
  • src/robusta/runner/web.py

Walkthrough

The src/robusta/runner/web.py file is modified to check the ENABLE_TELEMETRY environment flag in the Web._check_version() method. When telemetry is disabled, the method returns None immediately instead of fetching runner version information.

Changes

Cohort / File(s) Summary
Telemetry Flag Integration
src/robusta/runner/web.py
Added ENABLE_TELEMETRY environment flag import and conditional check in _check_version() to skip version fetching when telemetry is disabled.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to evaluate whether the description relates to the changeset. Add a pull request description explaining the purpose and context of disabling the version check when telemetry is disabled.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: disabling the version check when telemetry is disabled, which matches the modification to Web._check_version().

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch block-saas-api-call

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

Docker image ready for 9fad985 (built in 3m 48s)

⚠️ Warning: does not support ARM (ARM images are built on release only - not on every PR)

Use this tag to pull the image for testing.

📋 Copy commands

⚠️ Temporary images are deleted after 30 days. Copy to a permanent registry before using them:

gcloud auth configure-docker us-central1-docker.pkg.dev
docker pull us-central1-docker.pkg.dev/robusta-development/temporary-builds/robusta-runner:9fad985
docker tag us-central1-docker.pkg.dev/robusta-development/temporary-builds/robusta-runner:9fad985 me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:9fad985
docker push me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:9fad985

Patch Helm values in one line:

helm upgrade --install robusta robusta/robusta \
  --reuse-values \
  --set runner.image=me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:9fad985

@RoiGlinik RoiGlinik merged commit c147b7d into master Apr 9, 2026
7 checks passed
@RoiGlinik RoiGlinik deleted the block-saas-api-call branch April 9, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants