Add custom User-Agent header support for Mattermost integration#2045
Open
ckaytev wants to merge 1 commit intorobusta-dev:masterfrom
Open
Add custom User-Agent header support for Mattermost integration#2045ckaytev wants to merge 1 commit intorobusta-dev:masterfrom
ckaytev wants to merge 1 commit intorobusta-dev:masterfrom
Conversation
Signed-off-by: ckaytev <anton-ckayt@mail.ru>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
WalkthroughThis pull request adds optional Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the ability to override the default
User-Agentheader for Mattermost API requests.Problem
Many enterprise environments deploy WAF solutions that automatically block or flag requests containing default HTTP client user agents (e.g.,
python-requests,python/3.12). This causes Robusta's Mattermost integration to fail in such environments, preventing alert notifications from being delivered.By allowing users to customize the User-Agent header, Robusta can now work seamlessly in environments with strict WAF policies.
Configuration Example
Backward Compatibility
This change is fully backward compatible. The
user_agentparameter is optional and defaults toNone. When not specified, the behavior remains unchanged (no custom User-Agent header is set, and the underlying HTTP client uses its default).Testing
user_agent