Add support for Azure Workload Identity#12
Open
EppO wants to merge 1 commit intorobusta-dev:masterfrom
Open
Conversation
10b94ca to
4625652
Compare
Author
|
To test it you need to follow this guide: https://learn.microsoft.com/en-us/azure/aks/workload-identity-deploy-cluster In a nutshell:
|
|
Hi @EppO, thanks for the PR, I'm working on testing this PR. Do you have a test file used to test this? Also can you please update the docs in the README about how to use this? |
2e962c6 to
9279ea1
Compare
Author
|
Hi @pavangudiwada, sorry for the late reply. I rebased the PR on top of the latest master, I added documentation how to use it and added some sensible default values when using Azure. |
8dfa5a4 to
51c330e
Compare
8bad7e4 to
e116768
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another take based on robusta-dev/robusta#975