feat: support tencentcloud remote store#18
Open
fengxsong wants to merge 4 commits intorobertlestak:mainfrom
Open
feat: support tencentcloud remote store#18fengxsong wants to merge 4 commits intorobertlestak:mainfrom
fengxsong wants to merge 4 commits intorobertlestak:mainfrom
Conversation
Owner
|
@fengxsong this is awesome thank you! conceptually, the as this is quite a significant PR (and I have a day job 😄) please allow me some time to review and test in my environment, but do know this is on my radar and i am excited to get this merged in! |
Signed-off-by: fengxsong <fengxsong@outlook.com>
Signed-off-by: fengxsong <fengxsong@outlook.com>
Signed-off-by: fengxsong <fengxsong@outlook.com>
Signed-off-by: fengxsong <fengxsong@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR support
tencentcloudas remote store. besides it does the following changesStoreCreatorinterface, then every remote stores can focused on their own implementation without taking too much changes in theNewStorefunction. (the changes might be somewhat significant in a single PR, and, of course, you might feel that these changes are unnecessary :( )