feat: Add line border properties to LineLayer#4107
Open
Fl0h0 wants to merge 3 commits intornmapbox:mainfrom
Open
feat: Add line border properties to LineLayer#4107Fl0h0 wants to merge 3 commits intornmapbox:mainfrom
Fl0h0 wants to merge 3 commits intornmapbox:mainfrom
Conversation
- Introduced `lineBorderWidth`, `lineBorderWidthTransition`, `lineBorderColor`, and `lineBorderColorTransition` properties to enhance line styling capabilities. - Updated Android and iOS implementations to support new properties. - Enhanced documentation to include descriptions and usage examples for the new line border attributes. This update allows for more customizable line styles in the mapping interface.
mfazekas
reviewed
Dec 7, 2025
Contributor
|
@Fl0h0 getting better 👍 . See ci failures, I think we need to solve v10 compatibility: Also on iOS: /Users/runner/work/maps/maps/ios/RNMBX/RNMBXStyle.swift:1394:17: error: value of type 'LineLayer' has no member 'lineBorderWidth'
layer.lineBorderWidth = styleValue.mglStyleValueNumber();
~~~~~ ^~~~~~~~~~~~~~~
/Users/runner/work/maps/maps/ios/RNMBX/RNMBXStyle.swift:1401:11: error: value of type 'LineLayer' has no member 'lineBorderWidthTransition'
layer.lineBorderWidthTransition = styleValue.getTransition();
~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~
/Users/runner/work/maps/maps/ios/RNMBX/RNMBXStyle.swift:1408:17: error: value of type 'LineLayer' has no member 'lineBorderColor'
layer.lineBorderColor = styleValue.mglStyleValueColor();
~~~~~ ^~~~~~~~~~~~~~~
/Users/runner/work/maps/maps/ios/RNMBX/RNMBXStyle.swift:1415:11: error: value of type 'LineLayer' has no member 'lineBorderColorTransition'
layer.lineBorderColorTransition = styleValue.getTransition(); |
Contributor
|
I'm also thinking on bumping version to 1.3.0 and supporting only v11 and new architure. To make things like this less painful |
Contributor
|
@Fl0h0 Can you pls rebase, we now dropped mapbox 10 and old arch on main?! |
Author
That's great, removing the need for all the version 10 checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lineBorderWidth,lineBorderWidthTransition,lineBorderColor, andlineBorderColorTransitionproperties to enhance line styling capabilities.This update allows for more customizable line styles in the mapping interface.