feat: allow merging StyleImport configs#3619
Open
bvanderdrift wants to merge 1 commit intornmapbox:mainfrom
Open
feat: allow merging StyleImport configs#3619bvanderdrift wants to merge 1 commit intornmapbox:mainfrom
bvanderdrift wants to merge 1 commit intornmapbox:mainfrom
Conversation
Contributor
|
@bvanderdrift thanks much looks amazing. 👍 |
mfazekas
reviewed
Sep 12, 2024
Contributor
mfazekas
left a comment
There was a problem hiding this comment.
Looks good, but we'd need to add to new architecture src/specs/RNMBXStyleImportNativeComponent.ts and co.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added optional
mergeproperty toStyleImportthat allows merging an import config with the existing style import config, instead of full override.Defaults to
falsewhen not defined, to stay in line with current behaviour ofStyleImport.I haven't tested this on the example app and/or added an example, since I'm on some strict deadlines. Would love to get some help getting this PR over the finish line.
Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp./example)Screenshot OR Video
Tested this both on iOS & Android, but for simplicity I only added iOS demo video's here.
Test explained: the map style has both POI not showing & light mode dusk.
mergeunsetExpected: full override, so 'POI showing' falls back to default (
true).Screen.Recording.2024-09-11.at.10.24.53.mov
merge: falseExpected: full override, so 'POI showing' falls back to default (
true).Screen.Recording.2024-09-11.at.10.26.52.mov
merge: trueExpected: merging style, so 'POI showing' stays as defined in the style (
false).Screen.Recording.2024-09-11.at.10.27.26.mov
Component to test with