Skip to content

Cache unwrap and to_type_signature on type wrappers #5585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmosolgo merged 1 commit into from
Mar 25, 2026
+9 −3
Merged

Cache unwrap and to_type_signature on type wrappers #5585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/graphql/schema/list.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def list?
end

def to_type_signature
"[#{@of_type.to_type_signature}]"
@type_signature ||= -"[#{@of_type.to_type_signature}]"
end

# This is for introspection, where it's expected the name will be `null`
Expand Down
2 changes: 1 addition & 1 deletion lib/graphql/schema/non_null.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def list?
end

def to_type_signature
"#{@of_type.to_type_signature}!"
@type_signature ||= -"#{@of_type.to_type_signature}!"
end

def inspect
Expand Down
8 changes: 7 additions & 1 deletion lib/graphql/schema/wrapper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,13 @@ def initialize(of_type)
end

def unwrap
@of_type.unwrap
@unwrapped ||= @of_type.unwrap
end

def freeze
unwrap
to_type_signature
super
end

def ==(other)
Expand Down
Loading