Open
Conversation
Owner
|
@shiyouping I'm wondering if it would be better to delegate the inclusion of metas, scripts and other stuff to the consumer instead of this lib. We could consider adding a callback that return the window reference. With that ref we will allow other consumers to do whatever that please them with the opened window. wdyt? Note: I'm aware on the time it took me to reply. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added two new props that will generate script tags and meta tags. As I am not familiar with typescript, I am not sure if my modification to NewWindow.d.ts is correct or not. If not, please help me to correct it if you want to merge my changes. Many thanks.