Fix images and React styles in generated windows#113
Open
mecirt wants to merge 3 commits intormariuzzo:mainfrom
Open
Fix images and React styles in generated windows#113mecirt wants to merge 3 commits intormariuzzo:mainfrom
mecirt wants to merge 3 commits intormariuzzo:mainfrom
Conversation
* Update styles in the new window whenever they change in the parent. This is needed if the application mounts new React components inside the new window (React updates those styles on-demand instead of loading them at start).
|
Why was the help wanted tag added? Do you want someone to verify this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed if the application mounts new React components inside
the new window (React updates those styles on-demand instead of
loading them at start).