Disable RedistInstall when DISABLESTEAMWORKS is defined #697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Additionally, I think it's relevant to mention that the current release (2024.8.0) does not use the version of It's using a much older version of the file, which has an additional bug in more recent versions. |
Contributor
|
I've created this other PR with a setting to avoid it from adding the defines at all: #712 |
Owner
|
With #712 merged in, let me know if we're still missing any piece of this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the
STEAMWORKS_NETdefine is always added to the scripting defines.If steamworks is disabled with
DISABLESTEAMWORKSor because it isn't compatible with the platform, it should not be added.Guards the file in constant bounds to check for the define.
Fixes #656