Skip to content

Fix pnpm-lock.yaml for sqlite-native dependencies#4570

Closed
NicholasKissel wants to merge 1 commit intomainfrom
NicholasKissel/fix-lockfile
Closed

Fix pnpm-lock.yaml for sqlite-native dependencies#4570
NicholasKissel wants to merge 1 commit intomainfrom
NicholasKissel/fix-lockfile

Conversation

@NicholasKissel
Copy link
Copy Markdown
Member

Summary

  • Regenerates pnpm-lock.yaml to include the 5 missing @rivetkit/sqlite-native-* platform dependencies added in rivetkit-typescript/packages/sqlite-native/package.json
  • Fixes ERR_PNPM_OUTDATED_LOCKFILE build failure in CI

Test plan

  • CI build passes with --frozen-lockfile

@railway-app
Copy link
Copy Markdown

railway-app bot commented Apr 6, 2026

🚅 Deployed to the rivet-pr-4570 environment in rivet-frontend

Service Status Web Updated (UTC)
frontend-inspector ❌ Build Failed (View Logs) Web Apr 6, 2026 at 11:53 pm
frontend-cloud ❌ Build Failed (View Logs) Web Apr 6, 2026 at 11:53 pm
website ❌ Build Failed (View Logs) Web Apr 6, 2026 at 11:52 pm
mcp-hub ✅ Success (View Logs) Web Apr 6, 2026 at 11:52 pm
kitchen-sink ❌ Build Failed (View Logs) Web Apr 6, 2026 at 11:52 pm
ladle ❌ Build Failed (View Logs) Web Apr 6, 2026 at 11:52 pm

@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4570 April 6, 2026 23:51 Destroyed
@claude
Copy link
Copy Markdown

claude bot commented Apr 6, 2026

PR Review

This is a lockfile-only change targeting a CI fix. A couple of observations:

Description vs. Diff Mismatch

The PR description says it "Regenerates pnpm-lock.yaml to include the 5 missing @rivetkit/sqlite-native-* platform dependencies", but the actual diff contains no additions of @rivetkit/sqlite-native-* entries. The three changed lines are all @hono/node-server version changes (1.19.12 → 1.19.9). This suggests either:

  • The description was written for an earlier version of this PR and the content changed, or
  • The sqlite-native entries were already present in the lockfile before this PR was opened.

It would be worth clarifying which sqlite-native entries were missing and confirming the CI failure is actually fixed by this change rather than something else.

Unintentional Version Downgrade

The @hono/node-server dependency is being downgraded from 1.19.12 to 1.19.9 in three places:

  • The importers section for the package that specifies ^1.19.1
  • Two snapshot entries for @modelcontextprotocol/sdk@1.25.3

Both versions satisfy the ^1.19.1 semver range, so this is valid. However, a downgrade in a lockfile regeneration is unexpected — typically regenerating picks the latest compatible version. This could indicate the lockfile was generated against a different package.json state or registry snapshot. It's harmless, but worth a sanity check to confirm the regeneration was done cleanly (e.g., fresh node_modules, correct registry).

Summary

Low risk change overall. The lockfile diff is minimal and correct from a semver standpoint. Recommend clarifying the description and confirming CI passes before merging.

@NicholasKissel
Copy link
Copy Markdown
Member Author

Superseded by #4571. The lockfile-only fix didn't work because the @rivetkit/sqlite-native-* packages haven't been published to npm yet. The real fix removes the unpublished optionalDependencies from package.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant