Skip to content

Conversation

@NathanFlurry
Copy link
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Member Author

NathanFlurry commented Feb 10, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link

claude bot commented Feb 10, 2026

Pull Request Review: chore: update examples

This PR updates example projects with improved documentation, new Vercel deployments, and standardized configurations. Overall, the changes look good but there are a few issues to address.


🟢 Positive Changes

Documentation Improvements

  • Consistent README format across all examples with proper clone/install/run instructions
  • Standardized to use npm commands instead of pnpm in READMEs for better accessibility
  • Added proper "Getting Started" sections to examples that were missing them
  • Added missing LICENSE sections

New Examples

  • per-tenant-database-vercel: Well-structured example demonstrating actor-based database isolation
  • sqlite-raw-vercel: Clean demonstration of raw SQLite integration

Vercel Deployment Support

  • Added proper .gitignore files to new Vercel examples
  • Consistent vercel.json configuration across examples
  • Proper turbo.json setup for monorepo integration

🔴 Issues & Concerns

1. Typo in PR Title

The PR title says "update exmaples" but should be "update examples".

2. Missing Vercel Example for per-tenant-database

According to CLAUDE.md, when adding/updating examples, you should ensure vercel equivalents are generated:

When adding new examples, or updating existing ones, ensure that the user also modified the vercel equivalent, if applicable.

The per-tenant-database example has a vercel version created, but in package.json at line 1020-1060, the providers object is populated. However, in the generated _gen.ts file at line 2034, the providers object is empty:

"providers": {}

This suggests the Vercel example generation may have failed or wasn't run properly.

3. Inconsistent Package Version Resolution

In examples/sqlite-drizzle/package.json:1509 and examples/sqlite-raw/package.json:1863, the rivetkit dependency was changed from:

"rivetkit": "workspace:*"

to:

"rivetkit": "*"

According to CLAUDE.md:

When adding RivetKit dependencies to examples in /examples/, use * as the version. The root resolutions will automatically resolve these to the local workspace packages.

While this change aligns with the documented pattern, it's unclear why only these two examples were updated. Should this be applied consistently to all examples?

4. Incomplete Vercel Example Generation

The examples/sqlite-raw-vercel/src/server.ts:1771 only contains:

import { registry } from "./registry";

registry.start();

This looks like the non-Vercel version. According to the pattern in other Vercel examples (e.g., per-tenant-database-vercel/src/server.ts:1177-1182), it should use Hono and export the app:

import { Hono } from "hono";
import { registry } from "./actors.ts";

const app = new Hono();
app.all("/api/rivet/*", (c) => registry.handler(c.req.raw));
export default app;

5. Extra Blank Lines in READMEs

Multiple README files have an unnecessary blank line after the code block (e.g., lines 15, 33, 61, 80, 111, 180, 199, etc.). Example:

npm run dev

Features


This adds visual inconsistency. Should be:
```markdown
npm run dev

Features


### 6. **Generated File Changes**
The `frontend/packages/example-registry/src/_gen.ts` file has significant reordering and changes. Was this intentionally regenerated, or is this an artifact of the generation script? The ordering changes (e.g., hello-world moving before ai-agent) suggest the generation logic changed.

### 7. **Missing Documentation Updates**
According to CLAUDE.md:
> When adding new docs pages, update `website/src/sitemap/mod.ts` so the page appears in the sidebar.

Are there any documentation pages that need updating for these new examples?

---

## 🟡 Minor Observations

### Package Metadata Changes
Several examples had their tags simplified:
- `geo-distributed-database`: Removed "state", "edge", "multi-region" tags, kept only "database"
- `per-tenant-database": Removed "state", "multi-tenant" tags, kept only "database"
- `sandbox`: Changed from "actors", "sandbox" to just "starter"

These changes seem intentional for better categorization, but it would be good to confirm this is the desired taxonomy.

### Removed `sqlite` Technology Tag
In `sqlite-raw/package.json:1872`, the `"sqlite"` technology was removed from the template. Is this intentional? It seems like a useful categorization.

---

## ✅ Recommendations

1. **Fix the PR title typo** from "exmaples" to "examples"
2. **Regenerate Vercel examples** by running `./scripts/vercel-examples/generate-vercel-examples.ts` to ensure consistency
3. **Fix sqlite-raw-vercel server.ts** to use proper Hono setup like other Vercel examples
4. **Run `pnpm install`** after regenerating to avoid type check errors (per CLAUDE.md notes)
5. **Remove extra blank lines** in README files for consistency
6. **Verify the per-tenant-database-vercel** deployment configuration is properly registered
7. **Consider whether the workspace:* → * change** should be applied to all examples consistently

---

## 🔒 Security Review
✅ No security concerns identified
- New actor implementations properly validate inputs (trim() on user input)
- SQL queries use parameterized statements to prevent injection
- No credential exposure or sensitive data leaks

---

## 🧪 Testing
According to CLAUDE.md, tests should be verified:
- The per-tenant-database-vercel includes unit tests (`tests/per-tenant-database.test.ts`)
- Tests look comprehensive and follow vitest patterns
- **Recommendation**: Run the test suite to ensure all examples still work

```bash
# Test new examples
cd examples/per-tenant-database-vercel && pnpm test
cd examples/sqlite-raw-vercel && pnpm test

Summary

This is good work on standardizing and improving the examples. The main blockers are:

  1. Vercel generation issues (incomplete or not run)
  2. Inconsistent server.ts in sqlite-raw-vercel

Once these are addressed and examples are properly regenerated, this should be ready to merge.

@NathanFlurry NathanFlurry marked this pull request as ready for review February 10, 2026 08:40
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 10, 2026

Merge activity

  • Feb 10, 8:45 AM UTC: NathanFlurry added this pull request to the Graphite merge queue.
  • Feb 10, 8:46 AM UTC: CI is running for this pull request on a draft pull request (#4166) due to your merge queue CI optimization settings.
  • Feb 10, 8:47 AM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #4081.
  • Feb 10, 8:48 AM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #4081.
  • Feb 10, 7:35 PM UTC: NathanFlurry added this pull request to the Graphite merge queue.
  • Feb 10, 7:36 PM UTC: CI is running for this pull request on a draft pull request (#4167) due to your merge queue CI optimization settings.
  • Feb 10, 7:36 PM UTC: Merged by the Graphite merge queue via draft PR: #4167.

graphite-app bot pushed a commit that referenced this pull request Feb 10, 2026
# Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update

## How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

## Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
@NathanFlurry NathanFlurry force-pushed the 02-09-chore_update_exmaples branch from d03839f to b249fff Compare February 10, 2026 19:25
@NathanFlurry NathanFlurry force-pushed the 02-09-fix_rivetkit_remove_top-level_promise_errors branch from e0e274e to 2c75012 Compare February 10, 2026 19:25
graphite-app bot pushed a commit that referenced this pull request Feb 10, 2026
# Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update

## How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

## Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
@graphite-app graphite-app bot closed this Feb 10, 2026
@graphite-app graphite-app bot deleted the 02-09-chore_update_exmaples branch February 10, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant