Fix bug in sqltemplate cache path around args order#1243
Merged
Conversation
Related to #1242. Activating caching everywhere revealed a bug in that we were adding named args using `maputil.Values`. The problem with this is that `maputil.Values` returns values in an arbitrary order, resulting in all kinds of odd things potentially happening during a query as args are switched around. Here, fix the problem by appending args in the same order as incoming map keys.
brandur
force-pushed
the
brandur-named-args-fix
branch
from
56bfe74 to
1d55eaf
Compare
Contributor
Author
|
@bgentry Mind taking a look at this one? Small bug fix. |
bgentry
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1242. Activating caching everywhere revealed a bug in that
we were adding named args using
maputil.Values. The problem with thisis that
maputil.Valuesreturns values in an arbitrary order, resultingin all kinds of odd things potentially happening during a query as args
are switched around.
Here, fix the problem by appending args in the same order as incoming
map keys.