Skip to content

Conversation

@pjain1
Copy link
Member

@pjain1 pjain1 commented Jan 20, 2026

  • Add AI-powered scheduled insight reports with new format (format: ai_session) on existing report.
  • Implement AI resolver that creates AI sessions by default with analyst agent for completing user prompt

On reconciliation, an AI resolver is created which generates an AI session with analyst_agent and a slightly modified system prompt for scheduled report, upon competition it include a summary and send out the session id link to the recipient.

Report modes behaviour

Recipient mode - In this mode, AI report is run with each recipient attributes and a separate session is created for them.

Creator mode - In this mode, a single session is created with owners attribute (without any charts as it required mv agg for rendering), this session is a shared session and a magic token is used for viewing this session (this mgc token has no access just used for authentication), for continuing conversation user should be logged in and conversation should be forked.

Format

Reports can now use format: ai_session to generate AI-powered insights instead of traditional query exports. Example YAML:

  type: report
  format: ai_session
  data:
    ai:
      agent: analyst_agent
      prompt: 
      time_range:
        iso_duration: P7D
        time_zone: UTC
      comparison_time_range:
        iso_duration: P7D
        iso_offset: P7D
      context:
        explore: my_dashboard

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@pjain1 pjain1 marked this pull request as draft January 20, 2026 13:33
@pjain1 pjain1 changed the title Ai reports AI reports Jan 20, 2026
@pjain1 pjain1 changed the title AI reports [PLAT-334] AI reports Jan 20, 2026
}

const llmRequestTimeout = 60 * time.Second
const llmRequestTimeout = 90 * time.Second
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After all the tool calls, sometimes it would take more than 1 minute for LLM to synthesize the final output. So had to increase it.

@pjain1 pjain1 requested a review from begelundmuller January 26, 2026 05:13
@pjain1 pjain1 marked this pull request as ready for review January 26, 2026 05:13
bool intervals_check_unclosed = 15;
// AI report configuration
string format = 17; // "query" (default) or "ai_session"
AIReportConfig ai_config = 18; // Configuration for AI-powered reports (only used when format = "ai_session")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you look at alerts, they have generic resolver and resolver_properties fields:

  • string resolver = 13;
    google.protobuf.Struct resolver_properties = 14;
    // DEPRECATED: Use resolver and resolver_properties instead.
    string query_name = 3;
    // DEPRECATED: Use resolver and resolver_properties instead.
    string query_args_json = 4;
  • string resolver = 22;
    google.protobuf.Struct resolver_properties = 23;

We also intended to do the same for reports, but we never got around to it. However, with this change, rather than hard-code the AI resolver properties here, can we take a generic approach similar to alerts?

Comment on lines +648 to +654
// AITimeRange defines a time range using ISO 8601 duration strings.
// The time range is resolved at report execution time.
message AITimeRange {
string iso_duration = 1; // ISO 8601 duration (e.g., "P7D" for 7 days, "P1M" for 1 month)
string iso_offset = 2; // Optional ISO 8601 offset for comparison ranges (e.g., "P7D" to offset by 7 days)
string time_zone = 3; // IANA timezone (e.g., "America/New_York")
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears not to support Rill time expressions? I believe the UI only uses those for new reports (or otherwise, they will probably migrate to that soon).

Instead of a custom type, can it use our main TimeRange proto type, which we already have utils for converting into a concrete time range? Thinking about this one:

// 2 of the (start, end, iso_duration) should be set
message TimeRange {
// Optional. Defaults to min
google.protobuf.Timestamp start = 1;
// Optional. Defaults to max
google.protobuf.Timestamp end = 2;
// Optional, ie PT1M
string iso_duration = 3;
// Optional, ie PT1M
string iso_offset = 4;
TimeGrain round_to_grain = 5;
// Optional. IANA format, ie Europe/Copenhagen. Defaults to UTC
string time_zone = 6;
// Optional. Rill format time range. Should only be used for alerts and reports.
// For dashboard call ResolveTimeRanges.
string expression = 7;
string time_dimension = 8; // Optional. If not specified, falls back to the primary time dimension in the metrics view spec
}

ComparisonTimeStart time.Time `json:"comparison_time_start" yaml:"comparison_time_start" jsonschema:"Optional comparison period start time."`
ComparisonTimeEnd time.Time `json:"comparison_time_end" yaml:"comparison_time_end" jsonschema:"Optional comparison period end time."`
// scheduled insight report mode args
IsScheduledInsight bool `json:"is_scheduled_insight" yaml:"is_scheduled_insight" jsonschema:"Flag indicating this is an automated scheduled insight report."`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is an internal name, can we call it IsReport? "Scheduled insights" are more of a UI/marketing term

ComparisonTimeEnd time.Time `json:"comparison_time_end" yaml:"comparison_time_end" jsonschema:"Optional comparison period end time."`
// scheduled insight report mode args
IsScheduledInsight bool `json:"is_scheduled_insight" yaml:"is_scheduled_insight" jsonschema:"Flag indicating this is an automated scheduled insight report."`
HideCharts bool `json:"hide_charts" yaml:"hide_charts" jsonschema:"Flag indicating whether to suppress chart creation in the analysis."`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we call it DisableCharts instead? "Hide" sounds like they will still be created, but hidden.

Comment on lines +207 to +209
// Add scheduled insight mode context
data["is_scheduled_insight"] = args.IsScheduledInsight
data["is_scheduled_insight_user_prompt"] = args.IsScheduledInsight && !(strings.EqualFold(strings.TrimSpace(args.Prompt), "Generate the scheduled insight report."))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Doing a strings.EqualFold seems kind of unsafe in case we change that text upstream. Would it be possible to keep the prompt empty (so we can do if eq .prompt ""), and inject the "Generate ..." prompt in userPrompt when prompt is empty and IsScheduledInsight is true?
  2. Nit: Can you move this up to the initial data := statement like the other props?

Comment on lines 551 to +558
case "email":
recipients := pbutil.ToSliceString(notifier.Properties.AsMap()["recipients"])
for _, recipient := range recipients {
opts := &email.ScheduledReport{
ToEmail: recipient,
ToName: "",
DisplayName: rep.Spec.DisplayName,
ReportTime: t,
DownloadFormat: formatExportFormat(rep.Spec.ExportFormat),
}
urls, ok := meta.RecipientURLs[recipient]
if !ok {
return false, fmt.Errorf("failed to get recipient URLs for %q", recipient)
}
opts.OpenLink = urls.OpenURL
u, err := createExportURL(urls.ExportURL, t)
if err != nil {
return false, err
if rep.Spec.Format == "ai_session" {
reports := make(map[string]*aiReport)
for _, recipient := range recipients {
urls, ok := meta.RecipientURLs[recipient]
if !ok {
return false, fmt.Errorf("failed to get recipient URLs for %q", recipient)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic is getting pretty nested and hard to follow. Can you think of a way to simplify the flows?

Depending on your thoughts on my earlier comment about having a single SendScheduledReport function, maybe it can build the messages and send the messages in two separate steps, and become simpler that way?

if userID == "" || len(userAttrs) == 0 {
return nil, fmt.Errorf("no user attributes provided for AI report")
}
// TODO check project access for userID? as tool calls will just check metrics view access and if there are no security rules on mv then tool call will work but report open will fail later
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be addressed. How could it be addressed?

func buildAISessionURL(baseOpenURL, sessionID string) string {
// replace {session_id} in the baseOpenURL with the actual sessionID
return strings.ReplaceAll(baseOpenURL, "%7Bsession_id%7D", sessionID)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels a little hacky, had to jump back to the URL generation to check things here. Would be nice at least with a comment about this feature in the URLs generation function.

But also, I'm thinking if there's a way we can make this a bit more generic/clean. Another thing we need to support soon is precomputed report exports. Which is kind of similar to a pre-created AI session. I wonder if thinking about that use case as well could give us a cleaner path here.

For example, in alerts, we store the alert history in AlertState. Maybe we should keep similar history for reports? And then keep the existing reports/{name}/open link and let the UI redirect? Not sure.

Comment on lines +27 to +38
// Relative time range configuration may add exact start/end in the future
TimeRangeISODuration string `mapstructure:"time_range_iso_duration"`
TimeRangeTimeZone string `mapstructure:"time_range_time_zone"`
// Optional comparison time range
ComparisonTimeRangeISODuration string `mapstructure:"comparison_time_range_iso_duration"`
ComparisonTimeRangeISOOffset string `mapstructure:"comparison_time_range_iso_offset"`
// Optional dashboard context for the agent
Explore string `mapstructure:"explore"`
Dimensions []string `mapstructure:"dimensions"`
Measures []string `mapstructure:"measures"`
Where map[string]any `mapstructure:"where"`
// IsScheduledInsight indicates if the AI resolver is used for a scheduled insight.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using the *metricsview.TimeRange and *metricsview.Expression types similar to the metrics_sql resolver:

type metricsSQLProps struct {
// SQL is the metrics SQL to evaluate.
SQL string `mapstructure:"sql"`
// TimeZone is a timezone to apply to the metrics SQL.
TimeZone string `mapstructure:"time_zone"`
// AdditionalWhere is a filter to apply to the metrics SQL. (additional WHERE clause)
AdditionalWhere *metricsview.Expression `mapstructure:"additional_where"`
// AdditionalWhereByMetricsView is a map of metrics view names to filters to apply to the metrics SQL.
AdditionalWhereByMetricsView map[string]*metricsview.Expression `mapstructure:"additional_where_by_metrics_view"`
// AdditionalTimeRange is a time range filter to apply to the metrics SQL.
AdditionalTimeRange *metricsview.TimeRange `mapstructure:"additional_time_range"`
}

Comment on lines +236 to +237
// resolveTimeRange resolves the time range from ISO duration to actual timestamps.
func (r *aiResolver) resolveTimeRange() (start, end time.Time, err error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function seems to duplicate functionality from rilltime. It would be really nice if we could centralize on the rilltime implementation and not have time range resolution logic elsewhere.

See the code here for an example of how rilltime is used:

rillTime, err := rilltime.Parse(tr.Expression, rilltime.ParseOptions{

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants