-
Notifications
You must be signed in to change notification settings - Fork 164
feat (AI): UI for sharing AI conversations #8664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
AdityaHegde
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| // TESTS | ||
| // ============================================================================= | ||
|
|
||
| describe("Conversation", () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: lets move the tests just below mocks. It reads better IMO, tests 1st then all the utils and constants.
| setTimeout(() => { | ||
| copied = false; | ||
| isOpen = false; | ||
| }, 1500); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: move this to a constant.
| const shareConversationMutation = createRuntimeServiceShareConversation(); | ||
|
|
||
| async function handleCreateLink() { | ||
| if (isSharing || !conversationId || !organization || !project) return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clicking the button again makes a call to share again. Lets add a safeguard when the state is copied=true

Follows the Platform support, closes APP-643
Checklist: