Skip to content

Conversation

@ericpgreen2
Copy link
Contributor

@ericpgreen2 ericpgreen2 commented Jan 16, 2026

image

Follows the Platform support, closes APP-643

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@ericpgreen2 ericpgreen2 self-assigned this Jan 16, 2026
@ericpgreen2 ericpgreen2 marked this pull request as ready for review January 21, 2026 21:04
Copy link
Collaborator

@AdityaHegde AdityaHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The share button feels like out of place in full page chat. Can we move it closer to the center perhaps?
Screenshot 2026-01-22 at 11 22 32 AM

// TESTS
// =============================================================================

describe("Conversation", () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: lets move the tests just below mocks. It reads better IMO, tests 1st then all the utils and constants.

setTimeout(() => {
copied = false;
isOpen = false;
}, 1500);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: move this to a constant.

const shareConversationMutation = createRuntimeServiceShareConversation();

async function handleCreateLink() {
if (isSharing || !conversationId || !organization || !project) return;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clicking the button again makes a call to share again. Lets add a safeguard when the state is copied=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants