Skip to content

[codex] Add docs guides section#1298

Merged
jderochervlk merged 6 commits into
masterfrom
docs-guides-section
May 10, 2026
Merged

[codex] Add docs guides section#1298
jderochervlk merged 6 commits into
masterfrom
docs-guides-section

Conversation

@jderochervlk
Copy link
Copy Markdown
Collaborator

@jderochervlk jderochervlk commented May 9, 2026

This adds in a new section where we can add more detailed guides.

image

Context

This adds the initial top-level Guides section to the documentation nav without moving existing guide-like pages yet. The new section gives us a stable route and overview page before we decide which existing docs should move and how redirects/canonicals should be handled.

Changes

  • Added /docs/guides/overview backed by markdown-pages/docs/guides/overview.mdx.
  • Added DocsGuidesRoute.res/.resi using the existing docs MDX layout/sidebar pattern.
  • Registered guides MDX routes in DocsRoutes and added the typed path entry.
  • Added Guides to the secondary docs navbar between API and Syntax Lookup.
  • Updated Vitest and Cypress navigation coverage for the new nav item.

Follow-up Candidates

Existing guide-like pages that should be considered for a later move into markdown-pages/docs/guides:

  • docs/manual/rescript-for-javascript-developers.mdx
  • docs/manual/converting-from-js.mdx
  • docs/manual/project-structure.mdx
  • docs/manual/editor-code-analysis.mdx
  • React-specific candidates: docs/react/beyond-jsx.mdx, docs/react/extensions-of-props.mdx, docs/react/forwarding-refs.mdx

Those moves are intentionally left out of this draft because they need canonical URL and redirect decisions.

Validation

Pre-PR/rebased branch checks:

  • git diff --check --cached
  • yarn build:res
  • yarn workspace @rescript-lang/docs vitest:visual __tests__/visual/NavbarSecondary_.test.jsx --run --browser.headless

Additional validation from the implementation pass before opening the PR:

  • yarn workspace @rescript-lang/docs format
  • yarn workspace @rescript-lang/docs test
  • yarn workspace @rescript-lang/docs cypress run --spec e2e/Navigation.cy.jsx --browser electron
  • yarn workspace @rescript-lang/docs build:vite

Note: Cypress Chrome was unavailable in this environment, so the focused Cypress spec was run with Electron.

Adds a new /docs/guides/overview section, wires it into the docs route map and secondary navigation, and covers the new nav item in Vitest and Cypress navigation tests.
Move the existing docs/guidelines package publishing page into the guides section, wire it into the guides sidebar, and add a permanent redirect from the old URL.
Wait for the live Headless UI gallery transition before cloning the landing page section for visual snapshots, avoiding a transient hidden image state in CI.
Comment thread apps/docs/__tests__/visual/LandingPage_.test.res Outdated
@github-actions
Copy link
Copy Markdown

Cloudflare deployment

Deployement ID: 15bce2b9-b2e9-44a1-8d21-d2fecc079bf8
Deployment Environment: preview

⛅️ wrangler 4.85.0
───────────────────
✨ Compiled Worker successfully
Uploading... (8055/8057)
Uploading... (8056/8057)
Uploading... (8057/8057)
✨ Success! Uploaded 2 files (8055 already uploaded) (1.91 sec)

✨ Uploading _redirects
✨ Uploading Functions bundle
🌎 Deploying...
✨ Deployment complete! Take a peek over at https://15bce2b9.rescript-lang.pages.dev
✨ Deployment alias URL: https://docs-guides-section.rescript-lang.pages.dev

@jderochervlk jderochervlk merged commit cd6838a into master May 10, 2026
7 checks passed
@jderochervlk jderochervlk deleted the docs-guides-section branch May 10, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants