fix: use atomic rename in setup_subprocess_double_fork test#2815
Merged
markphelps merged 2 commits intomainfrom Mar 30, 2026
Merged
fix: use atomic rename in setup_subprocess_double_fork test#2815markphelps merged 2 commits intomainfrom
markphelps merged 2 commits intomainfrom
Conversation
…t race condition The forked child process writes .outbox directly, which means the predictor can observe the file (via os.path.exists) before the content is fully flushed. Write to .outbox.tmp first, then os.rename() to .outbox so the predictor never reads a partially-written file.
michaeldwan
approved these changes
Mar 23, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
markphelps
added a commit
that referenced
this pull request
Mar 30, 2026
….com/replicate/cog into mp/fix/dict-list-output-schema-fixes * 'mp/fix/dict-list-output-schema-fixes' of https://github.com/replicate/cog: (44 commits) bonk code reviews (#2892) fix: clarify env variable deny-list error message (#2813) fix: use atomic rename in setup_subprocess_double_fork test to prevent race condition (#2815) chore(deps): bump github.com/docker/cli (#2885) chore(deps): bump ureq from 3.2.0 to 3.3.0 in /crates (#2888) docs: fix HTTP discovery endpoint response to match Rust implementation (#2883) fix: support PEP 604 unions in File/Path coercion detection (#2878) fix: remove mise python venv config to silence warnings (#2879) refactor: extract homebrew tap into standalone reusable workflow (#2881) chore: 0.17.1 (#2877) review: replace string tags with FieldKind enum, add Debug derives, remove redundant test assertion (#2874) fix: app id in release workflow for homebrew tap (#2875) fix: don't coerce URL strings in str-typed inputs (regression #2868) (#2872) use GHCR mirror for cog-base images in integration tests (#2866) docs: improve documentation for input/output types (#2864) add workflow to mirror cog-base images from r8.im to GHCR (#2871) fix: bound fuzz tree size to prevent CI timeout in FuzzJSONSchema fix: guard against slice panic on single-char quoted strings in parseTypeFromString fix: address review issues in static schema generation Bump version to 0.17.0 ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setup_subprocess_double_forkintegration test that causes flaky CI failures.outboxdirectly, allowing the predictor to observe the file (viaos.path.exists) before content was fully flushed — resulting in"output":""instead of the expected value.outbox.tmpfirst, thenos.rename()to.outbox, so the predictor never reads a partially-written file