feat: Add validation for docker-cmd-file#822
Draft
lazytesting wants to merge 12 commits intorenovatebot:mainfrom
Draft
feat: Add validation for docker-cmd-file#822lazytesting wants to merge 12 commits intorenovatebot:mainfrom
lazytesting wants to merge 12 commits intorenovatebot:mainfrom
Conversation
viceice
requested changes
Feb 10, 2024
Merged
viceice
reviewed
Feb 12, 2024
viceice
reviewed
Feb 13, 2024
viceice
reviewed
Feb 13, 2024
Author
thanks for that, I added the async implementation |
viceice
reviewed
Feb 21, 2024
Comment on lines
+129
to
+130
| (s.mode & fs.constants.R_OK) === 0 || | ||
| (s.mode & fs.constants.X_OK) === 0 |
Member
There was a problem hiding this comment.
Suggested change
| (s.mode & fs.constants.R_OK) === 0 || | |
| (s.mode & fs.constants.X_OK) === 0 | |
| (s.mode & (fs.constants.R_OK | fs.constants.X_OK)) === 0 |
isn't this simpler?
Member
please use the re-request review button on PR to get another review |
Member
|
Marked as draft due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #817